Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where long tag names weren't clipped #12802

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jun 30, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: The length of tag names is not limited #12800...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Enter a long tag name and confirm it gets clipped

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 merged commit d309e5c into main Jun 30, 2023
@yaira2 yaira2 deleted the ya/TagsUI branch June 30, 2023 15:21
Comment on lines -344 to +345
Content="{helpers:ResourceString Name=SaveChanges}"
Content="{helpers:ResourceString Name=Save}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the string resource SaveChanges also be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, you're right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: The length of tag names is not limited
2 participants