Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Added "Size on disk" property to the Properties window #12777

Merged
merged 12 commits into from
Jul 10, 2023
Merged

Feature: Added "Size on disk" property to the Properties window #12777

merged 12 commits into from
Jul 10, 2023

Conversation

manfromarce
Copy link
Contributor

@manfromarce manfromarce commented Jun 28, 2023 •
edited
Loading

This PR adds Size on disk to the Properties window like Windows Explorer.

Resolved / Related Issues
Should close #3930.

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    I just checked Properties for different types of items (file, directory, link, recycle bin item, zipped item)

Screenshots (optional)
Immagine 2023-06-28 152944

@yaira2
Copy link
Member

yaira2 commented Jun 28, 2023

Are there any other steps that were used to validate these changes

Thank you for the PR. Can you fill this out this section? It helps accelerate the testing and review process.

@yaira2 yaira2 requested a review from 0x5bfa June 28, 2023 19:38
QuaintMako
QuaintMako reviewed Jun 29, 2023
View reviewed changes
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks pretty clean and like it does its job. I cannot test it for now though.

src/Files.App/ViewModels/Properties/Items/CombinedProperties.cs Outdated Show resolved Hide resolved
@QuaintMako
Copy link
Contributor

@yaira2 Should this be add to the Preview Pane as well?

@yaira2
Copy link
Member

yaira2 commented Jul 3, 2023

Should this be add to the Preview Pane as well?

Not right now

@yaira2 yaira2 requested review from yaira2, QuaintMako and 0x5bfa July 9, 2023 14:27
QuaintMako
QuaintMako approved these changes Jul 9, 2023
View reviewed changes
Copy link
Contributor

@QuaintMako QuaintMako left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected.

Some conflicts on the merge will need to be fixed though.

0x5bfa
0x5bfa approved these changes Jul 9, 2023
View reviewed changes
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yaira2 yaira2 changed the title Feature: Add "Size on disk" to Properties window Feature: Added "Size on disk" to property to the Properties window Jul 9, 2023
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jul 9, 2023
@yaira2
Copy link
Member

yaira2 commented Jul 9, 2023

@manfromarce can you resolve the merge conflict?

@manfromarce
Copy link
Contributor Author

@manfromarce can you resolve the merge conflict?

It should be able to merge now

@yaira2 yaira2 merged commit e1f43cc into files-community:main Jul 10, 2023
@yaira2 yaira2 changed the title Feature: Added "Size on disk" to property to the Properties window Feature: Added "Size on disk" property to the Properties window Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuaintMako QuaintMako QuaintMako approved these changes

@0x5bfa 0x5bfa 0x5bfa approved these changes

@yaira2 yaira2 Awaiting requested review from yaira2

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Add size on disk info to the properties dialog for better cloud management
4 participants
@manfromarce @yaira2 @QuaintMako @0x5bfa