Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added dividers between status bar sections #12769

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jun 28, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Added dividers between status bar sections

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jun 28, 2023
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice change

src/Files.App/UserControls/StatusBarControl.xaml Outdated Show resolved Hide resolved
@yaira2 yaira2 self-assigned this Jun 28, 2023
@yaira2 yaira2 requested a review from 0x5bfa June 28, 2023 14:05
@yaira2 yaira2 merged commit bf61eed into main Jun 28, 2023
@yaira2 yaira2 deleted the ya/StatusBarDividers branch June 28, 2023 16:33
@mdtauk
Copy link
Contributor

mdtauk commented Jun 28, 2023

Is there any merit in making this Divider/Separator into a control - rather than duplicating XAML?

@yaira2
Copy link
Member Author

yaira2 commented Jun 28, 2023

Is there any merit in making this Divider/Separator into a control - rather than duplicating XAML?

I usually only create a control if it's reused multiple times in multiple xaml files.

@mdtauk
Copy link
Contributor

mdtauk commented Jun 28, 2023

Also why is this using the Control Stroke colour, and not the Divider colour?
DividerStrokeColorDefaultBrush

@yaira2
Copy link
Member Author

yaira2 commented Jun 28, 2023

The status bar is using DividerStrokeColorDefaultBrush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants