Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Format project XML files #12740

Merged
merged 10 commits into from
Jul 4, 2023

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jun 26, 2023

Code Quality: Format project XML files

Motivation & Context

  • Improved readability.
  • Improve maintainability.

Warning
Please do not review code lines that I did not changed. I cannot make more diff. If there're more codes that are preferred to change, I will do that and mark that PR as the final one for that stage.

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related Feature: Improving Performance, optimizations, reliability and codebase  #4180
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots

None

Copy link
Member Author

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make review fast, I left some comments.

src/Files.App (Package)/Files.Package.wapproj Show resolved Hide resolved
src/Files.App (Package)/Package.appinstaller Outdated Show resolved Hide resolved
src/Files.App (Package)/Package.appxmanifest Show resolved Hide resolved
src/Files.App (Package)/Package.appxmanifest Show resolved Hide resolved
src/Files.App/Files.App.csproj Outdated Show resolved Hide resolved
src/Files.App/Files.App.csproj Show resolved Hide resolved
src/Files.App/Files.App.csproj Show resolved Hide resolved
@yaira2 yaira2 added changes requested Changes are needed for this pull request and removed needs - code review labels Jun 28, 2023
@0x5bfa 0x5bfa closed this Jun 29, 2023
@0x5bfa
Copy link
Member Author

0x5bfa commented Jun 29, 2023

Moved to #12790

@yaira2
Copy link
Member

yaira2 commented Jun 29, 2023

@0x5bfa this makes it really hard to review. Other than the one requested change, this PR was ready to merge. Moving it to a new PR requires reviewing it all over again.

@0x5bfa 0x5bfa reopened this Jun 29, 2023
@0x5bfa
Copy link
Member Author

0x5bfa commented Jun 29, 2023

Right, there's no need to move away. I'll keep this.

@0x5bfa
Copy link
Member Author

0x5bfa commented Jul 4, 2023

Ready for review.

@0x5bfa 0x5bfa requested a review from yaira2 July 4, 2023 02:54
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Jul 4, 2023
@yaira2 yaira2 merged commit 6c28520 into files-community:main Jul 4, 2023
@0x5bfa 0x5bfa deleted the 5bfa/format-xmlfiles branch July 6, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants