Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added option to hide the Send To menu #12674

Merged
merged 8 commits into from
Jun 22, 2023
Merged

Feature: Added option to hide the Send To menu #12674

merged 8 commits into from
Jun 22, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jun 21, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Add option to hide "send to" menu #12546...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Confirm the Send To menu only shows when the setting is enabled
    2. Test in the widgets as well

Screenshots (optional)
Add screenshots here.

@hishitetsu
Copy link
Member

Support for widgets isn't working well.
I think it would work to check the settings here instead.

// Add items to sendto dropdown
if (sendToItem?.LoadSubMenuAction is not null)

@yaira2
Copy link
Member Author

yaira2 commented Jun 21, 2023

Support for widgets isn't working well.

Which widget?

@hishitetsu
Copy link
Member

Both widgets. All widgets and the sidebar use this method to generate a context menu.

@yaira2
Copy link
Member Author

yaira2 commented Jun 21, 2023

@hishitetsu can you check again?

@hishitetsu
Copy link
Member

@hishitetsu can you check again?

It still doesn't work well. I'll look into it.

@hishitetsu
Copy link
Member

@yaira2 This PR should fix the widgets problem.
#12684

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 22, 2023
@yaira2 yaira2 merged commit 0e5691a into main Jun 22, 2023
@yaira2 yaira2 deleted the ya/SendTo branch June 22, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add option to hide "send to" menu
2 participants