Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where the preview pane didn't update when switching panes #12647

Merged
merged 3 commits into from
Jun 19, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

@hishitetsu hishitetsu marked this pull request as draft June 19, 2023 04:02
@hishitetsu hishitetsu marked this pull request as ready for review June 19, 2023 04:15
@hishitetsu hishitetsu requested a review from yaira2 June 19, 2023 04:18
@yaira2 yaira2 changed the title Fix: Fixed issue where the preview pane wasn't update correctly when switching pane Fix: Fixed issue where the preview pane didn't update when switching panes Jun 19, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit a2dcb40 into files-community:main Jun 19, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jun 19, 2023
@hishitetsu hishitetsu deleted the FixPreviewWhenSwitchingPane branch June 19, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Preview Pane does not refresh when switching pane in Dual Pane
2 participants