Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed tab navigation when middle-clicking a sidebar item #12620

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Jun 15, 2023

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open C:\Program Files.
    2. Middle-click a sidebar item to open the location in new tab.
    3. Click C:\Program Files tab.
    4. It will show C:\Program Files. Without this fix, it will open C:.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 16, 2023
@yaira2 yaira2 merged commit eb05526 into files-community:main Jun 16, 2023
@hishitetsu hishitetsu deleted the SidebarMiddleClick branch June 16, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Folders scroll to the top after using mouse wheel to open a folder in new tab
2 participants