Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Show a progress ring or bar while loading in the properties window #12544

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

hishitetsu
Copy link
Member

In addition to during properties loading, a progress bar is now displayed during hash value calculation.

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots
Details tab:
image

Hashes tab:
image

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jun 5, 2023
@yaira2 yaira2 merged commit 05a2a67 into files-community:main Jun 5, 2023
@hishitetsu hishitetsu deleted the ShowProgress branch June 5, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Show a progress ring while loading the properties details page
2 participants