Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added "install" toolbar button for certificate files #12518

Merged
merged 5 commits into from
Jun 4, 2023

Conversation

br1trs
Copy link
Contributor

@br1trs br1trs commented Jun 1, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Add "Install" toolbar button for certificate files #12482

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click on any .cer, .crt, .pfx, and .der files.

Screenshots (optional)
image
image
image

@yaira2
Copy link
Member

yaira2 commented Jun 1, 2023

Thank you for the pull request, this looks very good.

@yaira2 yaira2 changed the title Feature: add "install" toolbar button for certificate files Feature: Added install toolbar button for certificate files Jun 1, 2023
@yaira2 yaira2 changed the title Feature: Added install toolbar button for certificate files Feature: Added "install" toolbar button for certificate files Jun 1, 2023
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code wise, I cannot test it though.

yaira2
yaira2 previously approved these changes Jun 4, 2023
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 4, 2023
@yaira2 yaira2 merged commit 11aca8f into files-community:main Jun 4, 2023
@br1trs br1trs deleted the install_certificate_files branch June 29, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add "Install" toolbar button for certificate files
4 participants