Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added horizontal layout to the preview pane #12496

Merged
merged 2 commits into from
May 31, 2023
Merged

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented May 30, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes #issue...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open preview pane
    2. Verify the preview is on top and the details on the bottom
    3. Switch to the preview tab and verify the preview is centered
    4. Resize app until the preview pane is moved to the bottom
    5. Verify that the preview is shown on the left and the details on the right
    6. Switch to the preview tab and verify that the preview is centered

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 31, 2023
@yaira2 yaira2 merged commit 61b4128 into main May 31, 2023
@yaira2 yaira2 deleted the ya/PreviewPane branch May 31, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant