Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added Git columns to the details layout #12485

Merged
merged 72 commits into from
Jun 13, 2023

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented May 29, 2023

Feature: Added Git columns to the details layout

Added some git columns for git repos.

Tasks

  • Added git columns (git Status, last commit date, message, author, and SHA).
  • Added an ability to show git info for each item.
  • Added an ability to customize git columns width.
  • Added an ability to hide and/or show git columns
  • Added an ability to store git columns visibility preferences.
  • Added an ability to store git columns width preferences.
  • Added an ability to make all git columns to fit.
  • Added an ability to set git columns hide/show preferences as default.
  • Added an ability to sort
  • Brush up...

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Added git columns to the details layout #12431
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app.
    2. Go to repository dir.
    3. See what happen next.

Screenshots

Overall
image

Status: File(s) modified
image

@yaira2
Copy link
Member

yaira2 commented May 29, 2023

It's not in the mockup but we can do commit author and commit hash as well.

@0x5bfa 0x5bfa marked this pull request as ready for review June 1, 2023 14:51
@yaira2 yaira2 self-requested a review June 2, 2023 01:42
@yaira2 yaira2 changed the title Feature: Add Git Columns Feature: Added Git columns to the details layout Jun 2, 2023
@yaira2
Copy link
Member

yaira2 commented Jun 2, 2023

A couple of behaviors that I think should be tested are

  • resizing every column
  • double click the header divider for every column and make sure the column is resized to fit
  • right click every header and test the size to fit menu option

@gave92 @chingucoding can you think of any other behaviors to test as a result of these changes?

@gave92
Copy link
Member

gave92 commented Jun 2, 2023

Great work @0x5bfa 💪. I've opened a PR to your repo (0x5bfa#1) with some suggested changes. The most important is to load git properties in LoadExtendedItemProperties() instead of Win32StorageEnumerator, so it does not slow down file listing.

@0x5bfa
Copy link
Member Author

0x5bfa commented Jun 2, 2023

I just confirmed! Thank you, this is at work!

yaira2
yaira2 previously approved these changes Jun 11, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 11, 2023
@ferrariofilippo
Copy link
Contributor

I think you forgot to change the names in the xaml

image

@0x5bfa
Copy link
Member Author

0x5bfa commented Jun 11, 2023

I will not able to fix those today in your time zone. @yaira2 I am sorry.

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I would like to suggest some improvements.

@0x5bfa
Copy link
Member Author

0x5bfa commented Jun 13, 2023

@hishitetsu Let me do them later.

@hishitetsu
Copy link
Member

Tooltips haven't been added yet. Otherwise, no problems.

@yaira2 yaira2 merged commit a7e4679 into files-community:main Jun 13, 2023
@0x5bfa 0x5bfa deleted the 5bfa/implement-gitcolumns branch July 6, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Added git columns to the details layout
5 participants