Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added SeerPro support #12477

Merged
merged 2 commits into from
May 29, 2023
Merged

Feature: Added SeerPro support #12477

merged 2 commits into from
May 29, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented May 29, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related #8052... (this PR doesn't include switching between files)

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Install and open SeerPro
    2. Use space bar to toggle preview from Files

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 marked this pull request as ready for review May 29, 2023 04:22
@hishitetsu
Copy link
Member

Shouldn't there be an option to switch between QuickLook and Seer?

@yaira2
Copy link
Member Author

yaira2 commented May 29, 2023

I'm undecided, we'll definitely want an option once we add a built-in preview feature but until then, I'm not sure if there is a valid use case where a user has both apps installed at the same time.

@hishitetsu
Copy link
Member

There may be situations where the user would like to select a preview tool if we support PowerToys Peek, but it certainly may not be necessary just yet.

hishitetsu

This comment was marked as duplicate.

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2
Copy link
Member Author

yaira2 commented May 29, 2023

There may be situations where the user would like to select a preview tool if we support PowerToys Peek, but it certainly may not be necessary just yet.

We can work around this by putting PowerToys Peek as the last if statement, this way, if another provider is detected we know it's preferred.

@yaira2 yaira2 merged commit 1a91416 into main May 29, 2023
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 29, 2023
@yaira2 yaira2 deleted the ya/SeerPro branch May 29, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants