Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed network locations not appearing on the sidebar #12411

Merged
merged 7 commits into from
May 22, 2023

Conversation

gave92
Copy link
Member

@gave92 gave92 commented May 20, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes #issue...

Since becoming a view model, UpdateDrivesAsync() of NetworkDrivesViewModel was not being called anymore.

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Connect a network resource (e.g ftp server)
    2. Verify that it appears in the sidebar

Screenshots (optional)
Add screenshots here.
image

@ferrariofilippo
Copy link
Contributor

Shouldn't Network folder be the first entry?

@gave92
Copy link
Member Author

gave92 commented May 21, 2023

It should but since #10258 drives get re-ordered by path in SidebarViewModel. Don't think it was intentional for network drives (or cloud), I'll add a fix here.
Edit: done!

Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works for me!

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 22, 2023
@yaira2 yaira2 merged commit 271a416 into files-community:main May 22, 2023
@gave92 gave92 deleted the issue_netw branch May 22, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants