-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Quality: Clean up App.Filesystem phase 1 #12408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, but there are some little tweaks that would improve comments
src/Files.App/Filesystem/Cloud/Detector/SynologyDriveCloudDetector.cs
Outdated
Show resolved
Hide resolved
src/Files.App/Filesystem/FilesystemOperations/FileSystemProgress.cs
Outdated
Show resolved
Hide resolved
src/Files.App/Filesystem/FilesystemOperations/FileSystemProgress.cs
Outdated
Show resolved
Hide resolved
@0x5bfa are you going to push anything more here? |
I don't think so. By the way, thank you for reviewing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
It's a pleasure, you can learn a lot by reading other people's code |
Description
I didn't know what this namespace is for. So I started working on readability refactoring first (stage 2).
Motivation & Context
PR Checklist
Related Code Quality: Continued work to clean up entire project #12340
Screenshots
None