Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed an issue where right clicking empty space didn't clear selection #12404

Merged

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Right clicking blank space doesn't clear selected item #12402

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app
    2. Selected some items
    3. Right click on white space

@yaira2 yaira2 changed the title Fix: Right clicking empty space clears selection Fix: Fixed an issue where right clicking empty space didn't clear selection May 19, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label May 19, 2023
@yaira2 yaira2 merged commit 0a405be into files-community:main May 19, 2023
@ferrariofilippo ferrariofilippo deleted the Clear_Selection_On_Right_Click branch May 20, 2023 06:39
@yaira2
Copy link
Member

yaira2 commented Jun 1, 2023

@ferrariofilippo do you think this makes sense to do in the column layout as well? I'm undecided.

@ferrariofilippo
Copy link
Contributor Author

I think that would be the expected behaviour by most users

@yaira2
Copy link
Member

yaira2 commented Jun 2, 2023

I tested column layout again, it's not working if a single folder is selected but it does work if multiple folders are selected.

@ferrariofilippo
Copy link
Contributor Author

Ok, I'll look into this as soon as I can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Right clicking blank space doesn't clear selected item
2 participants