Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Clean up App.Shell #12399

Merged
merged 8 commits into from
May 21, 2023

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented May 19, 2023

Description

I didn't know what this namespace is for. So I started working on readability refactoring first (stage 2).

  1. Rename variables with preferred name to follow the guideline (The most likely to happen is that I rename property-backing-field from '_isHidden' to '_IsHidden')

Motivation & Context

  • Improved readability
  • Updated variables to be more accurate.

Warning
Please do not review code lines that I did not changed. I cannot make more diff. If there're more codes that are preferred to change, I will do that and mark that PR as the final one for that stage.

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related Code Quality: Continued work to clean up entire project #12340
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots

None

Copy link
Contributor

@hecksmosis hecksmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Files.App/Shell/ShellNewMenuHelper.cs Show resolved Hide resolved
Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most comments are about documentation, but overall LGTM
Also, why did you remove the versioning thing?

src/Files.App/Shell/ShellLibraryEx.cs Outdated Show resolved Hide resolved
src/Files.App/Shell/ShellLibraryEx.cs Outdated Show resolved Hide resolved
src/Files.App/Shell/ShellLibraryEx.cs Outdated Show resolved Hide resolved
src/Files.App/Shell/ShellLibraryEx.cs Outdated Show resolved Hide resolved
src/Files.App/Shell/ShellLibraryEx.cs Outdated Show resolved Hide resolved
src/Files.App/Shell/ShellLibraryEx.cs Outdated Show resolved Hide resolved
src/Files.App/Shell/ShellLibraryEx.cs Outdated Show resolved Hide resolved
src/Files.App/Shell/ShellLibraryEx.cs Outdated Show resolved Hide resolved
src/Files.App/Shell/ShellLibraryEx.cs Outdated Show resolved Hide resolved
src/Files.App/Shell/ShellLibraryEx.cs Outdated Show resolved Hide resolved
@0x5bfa
Copy link
Member Author

0x5bfa commented May 19, 2023

Thank you! I missed that file and oc I should do split. I'm going to do that later.

Also, why did you remove the versioning thing?

Minimum windows version is earlier than Files.App project minimum windows version. We should add them back when we introduce Uno or something. But for now adding only there is redundant.

PS, All done

Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x5bfa 0x5bfa requested a review from hecksmosis May 20, 2023 06:52
Copy link
Contributor

@hecksmosis hecksmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 21, 2023
@yaira2 yaira2 merged commit 1f78ff4 into files-community:main May 21, 2023
@0x5bfa 0x5bfa deleted the 5bfa/cleanup-shells branch June 9, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants