-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Quality: Clean up App.Shell #12399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most comments are about documentation, but overall LGTM
Also, why did you remove the versioning thing?
Thank you! I missed that file and oc I should do split. I'm going to do that later.
Minimum windows version is earlier than Files.App project minimum windows version. We should add them back when we introduce Uno or something. But for now adding only there is redundant. PS, All done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
I didn't know what this namespace is for. So I started working on readability refactoring first (stage 2).
Motivation & Context
PR Checklist
Related Code Quality: Continued work to clean up entire project #12340
Screenshots
None