Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Cleanup App.Dialogs #12381

Closed
wants to merge 8 commits into from

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented May 17, 2023

Description

A part of the #12340.

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related Code Quality: Continued work to clean up entire project #12340
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots

None

yaira2
yaira2 previously approved these changes May 18, 2023
@0x5bfa 0x5bfa marked this pull request as draft May 18, 2023 14:30
@0x5bfa
Copy link
Member Author

0x5bfa commented May 19, 2023

I have been intrusive; there's some extra work. I will reopen.

@0x5bfa 0x5bfa closed this May 19, 2023
@0x5bfa 0x5bfa deleted the 5bfa/cleanup-dialogs branch May 19, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants