Code Quality: Rename & Refactor ViewModels #12380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x5bfa
changed the title
0x5bfa
changed the title
yaira2
changed the title
Comment on lines
57
to
59
| { | ||
| if (FolderSettings is FolderSettingsViewModel viewModel) | ||
| if (FolderSettings is FolderSettingsService viewModel) | ||
| viewModel.DirectorySortOption = value; |
There was a problem hiding this comment.
Shouldn't you rename the variable from viewModel to simply model?
| CurrentInstanceViewModel InstanceViewModel { get; } | ||
| CurrentInstanceModel InstanceViewModel { get; } |
There was a problem hiding this comment.
What do you mean? I changed the suffix to Model. If you mean you are pointing variable naming, I font change yet because those previous viewmodels are referenced everywhere. Once I changed class name, diff became huge.(As i clarified in my cleaning up issue, it will be stage2:)
Comment on lines
+2230
to
+2231
| var isSystem = ((SystemIO.FileAttributes)findData.dwFileAttributes & SystemIO.FileAttributes.System) == SystemIO.FileAttributes.System; | ||
| var isHidden = ((SystemIO.FileAttributes)findData.dwFileAttributes & SystemIO.FileAttributes.Hidden) == SystemIO.FileAttributes.Hidden; |
There was a problem hiding this comment.
Isn't it System.IO?
Comment on lines
-382
to
+366
| public ItemViewModel(FolderSettingsViewModel folderSettingsViewModel) | ||
| public ItemViewModel(FolderSettingsService folderSettingsViewModel) |
| { | ||
| public static string LayoutSettingsDbPath | ||
| => SystemIO.Path.Combine(ApplicationData.Current.LocalFolder.Path, "user_settings.db"); | ||
| private IUserSettingsService UserSettingsService { get; } = Ioc.Default.GetRequiredService<IUserSettingsService>(); |
There was a problem hiding this comment.
Why don't you inject it in the constructor?
Comment on lines
+275
to
+277
|
|
||
| public FolderSettingsService() | ||
| { |
|
I have to split up more and more. Reopening. |
|
there was extra work... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title. Phase 1-2, it is actually a part of the phase 1.
PR Checklist
Related Code Quality: Continued work to clean up entire project #12340
Screenshots
None