Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Use gray and white grid in ColorPickerButton to indicate transparency #12371

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

Poker-sang
Copy link
Contributor

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Settings - Appearances - Theme Color

Screenshots (optional)
Expected

@Poker-sang
Copy link
Contributor Author

Poker-sang commented May 17, 2023

I thought it looks OK
light

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit ea3a5b3 into files-community:main May 17, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Use gray and white grid in ColorPickerButton to indicate transparency
2 participants