Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichCommands: CreateFolderWithSelection #12352

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related Generalizing Rich Command Usage #11481

Additional Notes

  • I added the copyright section to two files that were missing it
  • I cleaned up some rich command leftovers from ModernShellPage, ColumnShellPage and InnerNavigationToolbar

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app and navigate to a folder
    2. Right click to open the context menu
    3. See that Create folder with selected items is not visible
    4. Select some items
    5. Right click to open the context menu
    6. See that Create folder with selected items is visible
    7. Click on it

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 14, 2023
@yaira2 yaira2 merged commit 39b22c8 into files-community:main May 14, 2023
@ferrariofilippo ferrariofilippo deleted the RichCommands_Create_Folder_Selection branch May 14, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants