Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed crash when trying to create bitmap from null IconData in SidebarPinnedModel.cs #12333

Merged
merged 1 commit into from
May 11, 2023
Merged

Fix: Fixed crash when trying to create bitmap from null IconData in SidebarPinnedModel.cs #12333

merged 1 commit into from
May 11, 2023

Conversation

hecksmosis
Copy link
Contributor

Resolved / Related Issues

2023-05-11 18_05_33-DispatcherQueueExtensions EnqueueAsync T (DispatcherQueue dispatcher, Func`1 fu

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 changed the title Fix crash when trying to create bitmap from null IconData in SidebarPinnedModel.cs Fix: Fixed crash when trying to create bitmap from null IconData in SidebarPinnedModel.cs May 11, 2023
yaira2
yaira2 approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label May 11, 2023
@yaira2 yaira2 merged commit bea5c27 into files-community:main May 11, 2023
hishitetsu pushed a commit to hishitetsu/Files that referenced this pull request May 12, 2023
@hecksmosis @hishitetsu
Fix: Fixed crash when trying to create bitmap from null IconData in `…
95d9d6c 
…SidebarPinnedModel.cs` (files-community#12333)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hecksmosis @yaira2