Feature: Added support for grouping items by month

[hishitetsu]

Also fixed a minor bug where checkmarks for sort direction were not shown in the flyout.

Resolved / Related Issues

• Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  Closes Feature: Add support to group by month #12244

Validation
How did you test these changes?

• Did you build the app and test your changes?
• Did you check for accessibility? You can use Accessibility Insights for this.
• Did you remove any strings from the en-us resource file?
  • Did you search the solution to see if the string is still being used?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
• Are there any other steps that were used to validate these changes?

Screenshots

[0x5bfa]

In terms of codebase. Otherwise LGTM!

[0x5bfa]

Last thing.

[0x5bfa]

Can you not collapse by the reviewee-self other than 'Suggested changes'? Reviewers cannot see what you say or how you respond.

[0x5bfa]

LGTM

[hecksmosis]

Otherwise LGTM

[yaira2]

Would it be better to have "Group by month" be its own option instead of making it a sub option of "Group by date"?

[hishitetsu]

Would it be better to have "Group by month" be its own option instead of making it a sub option of "Group by date"?

I think so. There are several "Group by date" options, so it would be cleaner to add one sub option than to add monthly groupings to all of them.

[yaira2]

That's true, but it's still confusing to have the sub options the way they are. While I dislike nesting multiple sub menus, I think it's the best option here.

[hishitetsu]

While I dislike nesting multiple sub menus, I think it's the best option here.

If the submenus are nested, we have to open the nested submenus to see what they are grouped by. I think it is inconvenient.

[yaira2]

If the submenus are nested, we have to open the nested submenus to see what they are grouped by. I think it is inconvenient.

True, you don't see which one is selected without opening the menu but at least the options are grouped together. It's not apparent that the options go together if they aren't next to each other.

[hishitetsu]

I changed "Group by year" and "Group by month" to sub options of "Group by date".

[yaira2]

LGTM