Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where drives sometimes had the wrong thumbnail #12275

Merged
merged 2 commits into from
May 4, 2023

Conversation

hecksmosis
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: No Disk Icon in "Disk" Category #12251

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. See the thumbnail icons are now correct

Screenshots (optional)
Add screenshots here.

yaira2
yaira2 previously approved these changes May 4, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Fix: Fix sidebar thumbnail for drives Fix: Fixed issue where drives sometimes had the wrong thumbnail May 4, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label May 4, 2023
@hecksmosis
Copy link
Contributor Author

@yaira2 pushing this commit as the network folder lost its icon

@yaira2 yaira2 merged commit 079091b into files-community:main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: No Disk Icon in "Disk" Category
2 participants