Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Reset items opacity when copying other items #12252

Merged
merged 2 commits into from
May 1, 2023

Conversation

ferrariofilippo
Copy link
Contributor

@ferrariofilippo ferrariofilippo commented May 1, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Cut items stay translucent after copying other items #12249

I'm wondering if we should implement Esc to cancel cut as in file explorer....

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app
    2. Cut some items
    3. Select other items and select them
    4. See that items opacity resets

@ferrariofilippo
Copy link
Contributor Author

I'm wondering if we should implement Esc to cancel cut as in file explorer....

@hishitetsu what do you think about this?

@hishitetsu
Copy link
Member

I'm wondering if we should implement Esc to cancel cut as in file explorer....

@hishitetsu what do you think about this?

I didn't know about this feature. I don't need it. I think it is unnecessary until someone requests it.

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Fix: Reset cut items opacity when copying other items Fix: Reset items opacity when copying other items May 1, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label May 1, 2023
@yaira2 yaira2 merged commit ce2a09f into files-community:main May 1, 2023
@ferrariofilippo ferrariofilippo deleted the Cut_Opacity branch May 1, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Cut items stay translucent after copying other items
3 participants