Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Switch focus to the primary pane when closing dual pane mode #12213

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

ferrariofilippo
Copy link
Contributor

@ferrariofilippo ferrariofilippo commented Apr 26, 2023

…h shortcuts

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open two panes (Home and Home, if the primary pane was not on Home it worked even before)
    2. Click on the secondary pane
    3. Use Ctrl + Shift + W to close it
    4. Open a favorite from the sidebar (do not click on the primary pane)

@yaira2 yaira2 changed the title Fix: Fixed focus the primary pane when closing the secondary pane wit… Fix: Switch focus to the primary pane when closing dual pane mode Apr 26, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 26, 2023
@yaira2 yaira2 merged commit 8e66bc9 into files-community:main Apr 26, 2023
@ferrariofilippo ferrariofilippo deleted the Fix_Focus_Secondary_Pane branch July 17, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: When closing the secondary pane with a shortcut, the primary pane stops working as expected.
2 participants