-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Fixed an issue where folder icon customization apply before saving #12141
Fix: Fixed an issue where folder icon customization apply before saving #12141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and works for me!
Just a question: shouldn't private variables names start with a lowercase letter?
I don't know. I thought so as well but when I write private fields/properties as lower, IntelliSense suggestions have a ‘Name Violation’ item. I will fix. |
Yes, can you fix this? |
FYI(unrelated to this), By original functionality, if you switch tabs, props window will discard user changes unless we don't have Apply button or fix that issue. |
Description
Fix an issue which has been reported.
Motivation and Context
PR Checklist
Closes Bug: Folder customization are applied directly #11917
Screenshots
No response