Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed an issue where folder icon customization apply before saving #12141

Merged
merged 6 commits into from
Apr 30, 2023

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Apr 21, 2023

Description

Fix an issue which has been reported.

Motivation and Context

  • Do not change the icons when 'Restore' button clicked
  • Do not change the icons when an icon selected

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Folder customization are applied directly #11917
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app
    2. Open properties of a folder
    3. Switch tab to Customization
    4. Change icons

Screenshots

No response

@yaira2 yaira2 changed the title Fix: Fix an issue where folder icon customization get applied directly Fix: Fixed an issue where folder icon customization getsldapplied directly Apr 21, 2023
@yaira2 yaira2 changed the title Fix: Fixed an issue where folder icon customization getsldapplied directly Fix: Fixed an issue where folder icon customization apply before saving Apr 21, 2023
Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works for me!
Just a question: shouldn't private variables names start with a lowercase letter?

@0x5bfa
Copy link
Member Author

0x5bfa commented Apr 21, 2023

I don't know. I thought so as well but when I write private fields/properties as lower, IntelliSense suggestions have a ‘Name Violation’ item. I will fix.

@yaira2
Copy link
Member

yaira2 commented Apr 23, 2023

Just a question: shouldn't private variables names start with a lowercase letter?

Yes, can you fix this?

@yaira2 yaira2 requested review from ferrariofilippo and d2dyno1 and removed request for ferrariofilippo April 25, 2023 13:53
@0x5bfa
Copy link
Member Author

0x5bfa commented Apr 26, 2023

FYI(unrelated to this), By original functionality, if you switch tabs, props window will discard user changes unless we don't have Apply button or fix that issue.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Apr 30, 2023
@yaira2 yaira2 merged commit 8d4436b into files-community:main Apr 30, 2023
@0x5bfa 0x5bfa deleted the 5bfa/fix-customizationprops branch May 9, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Folder customization are applied directly
4 participants