-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RichCommand: PermanentlyDelete #12103
RichCommand: PermanentlyDelete #12103
Conversation
@hishitetsu fyi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Action names should begin with a verb.
Can you update CommandList.md as well?
Can we make it possible to perform permanent deletion when pressing the delete button on the toolbar or flyout while pressing |
@hishitetsu can you open a feature request to discuss this idea? |
Opened. |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM
Co-authored-by: hishitetsu <[email protected]>
Resolved / Related Issues
Related Generalizing Rich Command Usage #11481
Notes
This PR also removes some
KeyboardAccelerators
leftovers (Refresh
andDelete
)Validation
How did you test these changes?
Shift + Del
to permanently delete it orCtrl + D
to delete it