Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichCommand: PermanentlyDelete #12103

Merged

Conversation

ferrariofilippo
Copy link
Contributor

@ferrariofilippo ferrariofilippo commented Apr 17, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related Generalizing Rich Command Usage #11481

Notes
This PR also removes some KeyboardAccelerators leftovers (Refresh and Delete)

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • [] Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app and select a file
    2. Use Shift + Del to permanently delete it or Ctrl + D to delete it

@yaira2
Copy link
Member

yaira2 commented Apr 19, 2023

@hishitetsu fyi

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action names should begin with a verb.
Can you update CommandList.md as well?

src/Files.App/Commands/Manager/CommandManager.cs Outdated Show resolved Hide resolved
src/Files.App/Commands/CommandCodes.cs Outdated Show resolved Hide resolved
src/Files.App/Commands/Manager/CommandManager.cs Outdated Show resolved Hide resolved
src/Files.App/Commands/Manager/ICommandManager.cs Outdated Show resolved Hide resolved
src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved
@hishitetsu
Copy link
Member

hishitetsu commented Apr 19, 2023

Can we make it possible to perform permanent deletion when pressing the delete button on the toolbar or flyout while pressing Shift? File Explorer does.

@yaira2
Copy link
Member

yaira2 commented Apr 19, 2023

@hishitetsu can you open a feature request to discuss this idea?

@hishitetsu
Copy link
Member

@hishitetsu can you open a feature request to discuss this idea?

Opened.
#12117

@ferrariofilippo
Copy link
Contributor Author

ferrariofilippo commented Apr 19, 2023

Action names should begin with a verb. Can you update CommandList.md as well?

Done
Edit. I added also the missing commands from #12017

hishitetsu
hishitetsu previously approved these changes Apr 19, 2023
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM

@yaira2 yaira2 merged commit edd6336 into files-community:main Apr 19, 2023
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Apr 19, 2023
@ferrariofilippo ferrariofilippo deleted the RichCommands_PermanentDeletion branch April 19, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants