Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed grip splitter cursor behavior for preview pane and secondary pane #12047

Merged
merged 5 commits into from
Apr 14, 2023

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Apr 11, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Grid splitter shows wrong cursor #12046

Also simplifies a bit the logic for changing the grid splitter cursor for DetailsLayoutBrowser and MainPage.

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Check cursor behaviour when hovering over the pane splitter
    2. Check cursor behaviour when hovering over the preview pane splitter

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 changed the title Fix: Fix grip splitter cursor behaviour for preview pane and secondary pane Fix: Fixed grip splitter cursor behavior for preview pane and secondary pane Apr 11, 2023
Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works for me

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Apr 14, 2023
@yaira2 yaira2 merged commit 4d60f41 into files-community:main Apr 14, 2023
@gave92 gave92 deleted the fix_splitter branch April 14, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Grid splitter shows wrong cursor
3 participants