Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichCommands: Add Item & Edit Path #12011

Merged
merged 22 commits into from
Apr 30, 2023

Conversation

ferrariofilippo
Copy link
Contributor

@ferrariofilippo ferrariofilippo commented Apr 7, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related Generalizing Rich Command Usage #11481

Notes

  • I also remove many OnPropertyChanged from CurrentInstanceViewModel since they were not influencing those properties
  • I updated other Create actions to make sure they can be executed (they're not in recycle bin, ...)

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app
    2. Click new item button

@ferrariofilippo
Copy link
Contributor Author

@d2dyno1 I noticed that we are preventing the user from creating files (but not folders) on MTP devices and FTP, is there any reason for this?

@cinqmilleans
Copy link
Contributor

You can add KeyboardAcceleratorTextOverride on innerToolbar items (ToolbarNewFolderItem, ...) to display hotkeys. There are none but the user will be able to add his own.

@ferrariofilippo ferrariofilippo changed the title RichCommands: Add Item RichCommands: Add Item & Edit Path Apr 7, 2023
@ferrariofilippo
Copy link
Contributor Author

You can add KeyboardAcceleratorTextOverride on innerToolbar items (ToolbarNewFolderItem, ...) to display hotkeys. There are none but the user will be able to add his own.

I added it for Folder and Shortcut

@d2dyno1
Copy link
Member

d2dyno1 commented Apr 8, 2023

@d2dyno1 I noticed that we are preventing the user from creating files (but not folders) on MTP devices and FTP, is there any reason for this?

I think a limitation prevented creating files in MTP devices but @gave92 would probably know the answer

@gave92
Copy link
Member

gave92 commented Apr 8, 2023

I noticed that we are preventing the user from creating files (but not folders) on MTP devices and FTP, is there any reason for this?

For MTP devices it was intentional -> see #7212. This is because calling CreateFileAsync() in a MTP folder does not work. For FTP perhaps it could be enabled.

@yaira2 yaira2 requested a review from d2dyno1 April 18, 2023 05:28
@yaira2
Copy link
Member

yaira2 commented Apr 21, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Apr 30, 2023
@yaira2 yaira2 merged commit f52fda7 into files-community:main Apr 30, 2023
@ferrariofilippo ferrariofilippo deleted the RichCommands_Add_Item branch April 30, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants