Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Simplified the see more button on the tags widget #11988

Merged
merged 5 commits into from
Apr 16, 2023

Conversation

ferrariofilippo
Copy link
Contributor

@ferrariofilippo ferrariofilippo commented Apr 5, 2023

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots (optional)
Before:
Before_Dark Before_Light

After
After_Dark After_Light

@yaira2 yaira2 added changes requested Changes are needed for this pull request and removed needs - code review labels Apr 16, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Apr 16, 2023
@yaira2 yaira2 changed the title Feature: Replace See More string in Tags Home widget Feature: Simplified the see more button on the tags widget Apr 16, 2023
@yaira2 yaira2 merged commit 5f3f478 into files-community:main Apr 16, 2023
@ferrariofilippo ferrariofilippo deleted the Remove_See_More branch April 16, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Replace See More string in Tags Home widget with a right facing chevron
2 participants