Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Refactor LayoutPages & ShellPages #11929

Merged
merged 19 commits into from
Apr 2, 2023

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Apr 1, 2023

Code Quality: Refactor LayoutPages & ShellPages

Motivation and Context

  • Add comments in LayoutPages & ShellPages XAML files.
  • Refactor above files' code-behind

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots

No Response

@0x5bfa 0x5bfa changed the title Add comments in LayoutPages and ShellPages Code Quality: Refactor LayoutPages & ShellPages Apr 1, 2023
src/Files.App/IShellPage.cs Outdated Show resolved Hide resolved
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 2, 2023
@yaira2 yaira2 merged commit 75fbb7c into files-community:main Apr 2, 2023
@0x5bfa 0x5bfa deleted the 5bfa/add-xamlcomments3 branch April 19, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants