Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RichCommand: Show Properties #11915

Closed
wants to merge 20 commits into from
Closed

RichCommand: Show Properties #11915

wants to merge 20 commits into from

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Mar 31, 2023 •
edited
Loading

Description

Add a RichCommand Show Properties

Motivation and Context

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots

None

@ferrariofilippo
Copy link
Contributor

What about a keyboard shortcut? Maybe Ctrl + P (Properties) or Ctrl + I (Info)?

@yaira2
Copy link
Member

yaira2 commented Mar 31, 2023

What about a keyboard shortcut? Maybe Ctrl + P (Properties) or Ctrl + I (Info)?

We can leave without and let the user assign their own.

@0x5bfa 0x5bfa changed the title RichCommand: Show Properties RichCommand: Show Properties & Add XAML Comments Mar 31, 2023
@0x5bfa 0x5bfa requested a review from yaira2 March 31, 2023 17:31
@0x5bfa 0x5bfa mentioned this pull request Mar 31, 2023
Closed
78 tasks
@yaira2
Copy link
Member

yaira2 commented Mar 31, 2023

Add XAML comments in InnerNavigationToolbar.xaml

Can you open a separate PR for this? It makes it easier to refer back to the change (it also separates the changes in the changelog).

@0x5bfa 0x5bfa changed the title RichCommand: Show Properties & Add XAML Comments RichCommand: Show Properties Apr 1, 2023
@0x5bfa
Copy link
Member Author

0x5bfa commented Apr 1, 2023

It's annoying Tests frequently fails:(

yaira2
yaira2 previously approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 3, 2023
@yaira2
Copy link
Member

yaira2 commented Apr 3, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaira2
Copy link
Member

yaira2 commented Apr 3, 2023

@0x5bfa can you fix the merge conflict and look into why it's failing the automation tests?

@0x5bfa 0x5bfa closed this Apr 9, 2023
@0x5bfa 0x5bfa deleted the 5bfa/richcommand-showprops branch April 16, 2023 08:20
@ferrariofilippo
Copy link
Contributor

@0x5bfa are you still working on this? I'd want to open a PR to fix #12220, but I think it would be better to fix the bug once we have the rich command (so that we have to fix it only once)

@0x5bfa
Copy link
Member Author

0x5bfa commented Apr 28, 2023

I will try again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 left review comments

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x5bfa @ferrariofilippo @yaira2