Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: New enum Keys and KeyModifiers #11891

Merged
merged 8 commits into from
Apr 4, 2023

Conversation

cinqmilleans
Copy link
Contributor

@cinqmilleans cinqmilleans commented Mar 29, 2023

Resolved / Related Issues
Use new enums for keys.

  • Easier, faster and smarter HotKey instantiation.
  • Identifiers correspond to VirtualKey and VirtualKeyModifiers.
  • KeyModifiers have more key to avoid having to add them.
  • Only keys available, with a cleaner name.
  • Moving hotkey to a folder.
  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    The behavior doesn't change, it's simpler code.

@yaira2 yaira2 changed the title New enum Keys and KeyModifiers Feature: New enum Keys and KeyModifiers Mar 29, 2023
@yaira2 yaira2 requested a review from QuaintMako March 31, 2023 19:12
QuaintMako
QuaintMako previously approved these changes Apr 1, 2023
@yaira2
Copy link
Member

yaira2 commented Apr 3, 2023

@cinqmilleans can you fix the merge conflict?

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Apr 3, 2023
@cinqmilleans
Copy link
Contributor Author

It's merged.

@yaira2 yaira2 merged commit bc9f537 into files-community:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants