Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where the startup settings was ignored when launched from terminal #11866

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

hishitetsu
Copy link
Member

It's not approved yet, but I believe it should be fixed.

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open a terminal.
    2. Type "files.exe" and press enter.
    3. You will see that the startup settings are reflected.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 28, 2023
@yaira2 yaira2 merged commit 4e096d7 into files-community:main Mar 28, 2023
@hishitetsu hishitetsu deleted the FixLaunchFromTerminal branch March 28, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: The startup settings is ignored when launched from terminal with no parameters
2 participants