-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RichCommands: Open settings #11846
RichCommands: Open settings #11846
Conversation
|
General question: why do you guys never use |
Honestly, I've never heard of it. Isnt' it only supported by UWP and WPF? |
Binding to the strings allows us to have more control, it's also more readable since you can tell which properties are being translated at a glance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you add this to the documentation?
Please don't use the |
I'm sorry I always forget to change that |
Yeah sure |
Resolved / Related Issues
Closes Generalizing Rich Command Usage #11481
I'd like to add a shortcut. Which one is better:
Ctrl + S
,Alt + S
or anything else?Validation
How did you test these changes?