Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichCommands: Open settings #11846

Merged

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Generalizing Rich Command Usage #11481

I'd like to add a shortcut. Which one is better: Ctrl + S, Alt + S or anything else?

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open settings

@yaira2
Copy link
Member

yaira2 commented Mar 26, 2023

ctrl + ,

@Jay-o-Way
Copy link
Contributor

General question: why do you guys never use x:UID to fetch strings?
https://learn.microsoft.com/dotnet/desktop/xaml-services/xuid-directive

@ferrariofilippo
Copy link
Contributor Author

General question: why do you guys never use x:UID to fetch strings?

Honestly, I've never heard of it. Isnt' it only supported by UWP and WPF?

@yaira2
Copy link
Member

yaira2 commented Mar 26, 2023

Binding to the strings allows us to have more control, it's also more readable since you can tell which properties are being translated at a glance.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you add this to the documentation?

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 26, 2023
@yaira2 yaira2 mentioned this pull request Mar 26, 2023
78 tasks
@yaira2 yaira2 merged commit 9cd21ac into files-community:main Mar 26, 2023
@yaira2
Copy link
Member

yaira2 commented Mar 26, 2023

Please don't use the closes tag for these PRs 😃

@ferrariofilippo
Copy link
Contributor Author

Please don't use the closes tag for these PRs 😃

I'm sorry I always forget to change that

@ferrariofilippo ferrariofilippo deleted the RichCommands_OpenSettings branch March 26, 2023 18:32
@ferrariofilippo
Copy link
Contributor Author

Can you add this to the documentation?

Yeah sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generalizing Rich Command Usage
3 participants