Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichCommands: Reopen closed tabs #11833

Merged

Conversation

ferrariofilippo
Copy link
Contributor

@ferrariofilippo ferrariofilippo commented Mar 24, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related to Generalizing Rich Command Usage #11481

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open some tabs and then close them
    2. Reopen closed tabs using the shortcut or the context menu command

@yaira2
Copy link
Member

yaira2 commented Mar 27, 2023

Does this still work with continue where you left off?

@ferrariofilippo
Copy link
Contributor Author

Does this still work with continue where you left off?

I'll check which is the behaviour in Preview

@ferrariofilippo
Copy link
Contributor Author

It seems to work as in the preview:

  • Open new Tab -> The last closed tab will be opened
  • Continue where you left off -> No tab will be available to reopen

@yaira2
Copy link
Member

yaira2 commented Mar 27, 2023

Can you check what happens if you have "continue where you left off" and close Files with multiple tabs still open?

@ferrariofilippo
Copy link
Contributor Author

ferrariofilippo commented Mar 27, 2023

It opens all of them and the reopen shortcut is disabled
Are you having any issues?

@yaira2
Copy link
Member

yaira2 commented Mar 27, 2023

I didn't test yet, just wanted to confirm it was working on your end.

@yaira2
Copy link
Member

yaira2 commented Mar 27, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit a8dd473 into files-community:main Mar 27, 2023
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Mar 27, 2023
@ferrariofilippo ferrariofilippo deleted the RichCommands_ReopenClosedTab branch March 28, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants