Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichCommands: EnterCompactOverlay, ExitCompactOverlay, ToggleCompactOverlay #11821

Merged
merged 8 commits into from
Mar 23, 2023

Conversation

ferrariofilippo
Copy link
Contributor

@ferrariofilippo ferrariofilippo commented Mar 23, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Generalizing Rich Command Usage #11481

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app
    2. Hit F12 or Ctrl+Alt+Up or Ctrl+Alt+Down or use toolbar action

@ferrariofilippo ferrariofilippo marked this pull request as draft March 23, 2023 14:16
@ferrariofilippo ferrariofilippo marked this pull request as ready for review March 23, 2023 14:40
yaira2
yaira2 previously approved these changes Mar 23, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 23, 2023
@ferrariofilippo
Copy link
Contributor Author

I think the command itself is self-explanatory

@yaira2 yaira2 merged commit 94fb492 into files-community:main Mar 23, 2023
@hishitetsu
Copy link
Member

I think the command itself is self-explanatory

Yes, labels and descriptions can be the same. However, the description should be such that it is completely understandable what the action does, while labels are not always so.

@ferrariofilippo ferrariofilippo deleted the Overlays_RichCommands branch March 23, 2023 15:42
@QuaintMako QuaintMako mentioned this pull request Mar 23, 2023
78 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generalizing Rich Command Usage
4 participants