Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichCommand: Install Inf Driver #11812

Merged

Conversation

marcofranzen99
Copy link
Contributor

@marcofranzen99 marcofranzen99 commented Mar 22, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  • Relates Generalizing Rich Command Usage #11481
  • Implements RichCommand for InstallInfDriver
  • Fixed error if there is a space in the path of the .inf file

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Install button is hidden if no item is selected or in recycle bin
    2. For non-valid .inf files, an error message is displayed by windows when executing the command

I could not test a successful installation of an Inf Driver. Maybe someone else can test this, although the installation logic has not changed

yaira2
yaira2 previously approved these changes Mar 24, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2
Copy link
Member

yaira2 commented Mar 24, 2023

@mafra99 can you fix the merge conflicts?

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Mar 24, 2023
…InfDriver

# Conflicts:
#	src/Files.App/Commands/CommandCodes.cs
#	src/Files.App/Commands/Manager/CommandManager.cs
#	src/Files.App/Commands/Manager/ICommandManager.cs
@marcofranzen99
Copy link
Contributor Author

@yaira2 merge conflicts are solved & build is successful

@yaira2 yaira2 merged commit 1e117b2 into files-community:main Mar 24, 2023
@QuaintMako QuaintMako mentioned this pull request Mar 24, 2023
78 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants