-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Fixed issue with browsing WSL drives #11793
Fix: Fixed issue with browsing WSL drives #11793
Conversation
Co-authored-by: Filippo Ferrario <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't test it but there seems to be an error in the code logic
Co-authored-by: Filippo Ferrario <[email protected]>
What exectly do you mean with that? Is there anything else i should test? With the changes of this PR, the access to WSL distributions & network drives (with credentials) works for me: Files_3DNUvycpPr.mp4 |
I meant that you were normalizing the path but then you were using the raw path instead of the normalized one. Now you changed that and it's ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolved / Related Issues
Closes Bug: WSL File Browsing issue #11272
Validation
How did you test these changes?
Notes
AuthenticateNetworkShare
is needed for WSL distributions, it is now skipped