Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichCommand: Layout Sort Group #11678

Merged
merged 16 commits into from
Mar 16, 2023
Merged

Conversation

cinqmilleans
Copy link
Contributor

@cinqmilleans cinqmilleans commented Mar 12, 2023

Resolved / Related Issues
Add commands Layout Sort Group.

When the option "Sync layout and sorting preferences across directories", the adaptive layout is disable in toolbar but not in context menu. It's fixed.

The layout context menu replaces icons by toggle indicator. This lets you know which layout is active.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@yaira2
Copy link
Member

yaira2 commented Mar 12, 2023

Can you group related actions together instead of creating separate files for each one?

@cinqmilleans
Copy link
Contributor Author

It's done.

@yaira2
Copy link
Member

yaira2 commented Mar 12, 2023

The layout context menu replaces icons by toggle indicator. This lets you know which layout is active.

Doesn't MenuItem have support for an icon as well?

@cinqmilleans
Copy link
Contributor Author

Yes, but only a fonticon, not an opacityicon. The columns layout uses opacityicon. I tested with the tool icon + font icon, it's not aesthetic. I'll send a screenshot later.

@cinqmilleans
Copy link
Contributor Author

Here is a screenshot. We can find a trick for the image of columns.
Layout

@yaira2
Copy link
Member

yaira2 commented Mar 13, 2023

I'm going to be updating the other icons in the flyout as well, do you have any ideas on fixing the issue?

@cinqmilleans
Copy link
Contributor Author

It will probably be necessary to create a UserControl derived from ToggleMenuFlyoutItem (as it was done for the buttons). In the preview, the Columns icon is already missing in this context menu. I propose to deal with this problem in a future pr. I will commit the code with the check + icon.

@cinqmilleans
Copy link
Contributor Author

It's done.

@QuaintMako QuaintMako mentioned this pull request Mar 15, 2023
78 tasks
@yaira2
Copy link
Member

yaira2 commented Mar 16, 2023

@cinqmilleans can you fix the merge conflict?

@cinqmilleans
Copy link
Contributor Author

It's done.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Mar 16, 2023
@yaira2 yaira2 merged commit 46ebd77 into files-community:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants