-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RichCommand: Layout Sort Group #11678
Conversation
Can you group related actions together instead of creating separate files for each one? |
It's done. |
Doesn't MenuItem have support for an icon as well? |
Yes, but only a fonticon, not an opacityicon. The columns layout uses opacityicon. I tested with the tool icon + font icon, it's not aesthetic. I'll send a screenshot later. |
I'm going to be updating the other icons in the flyout as well, do you have any ideas on fixing the issue? |
It will probably be necessary to create a UserControl derived from ToggleMenuFlyoutItem (as it was done for the buttons). In the preview, the Columns icon is already missing in this context menu. I propose to deal with this problem in a future pr. I will commit the code with the check + icon. |
It's done. |
@cinqmilleans can you fix the merge conflict? |
It's done. |
Resolved / Related Issues
Add commands Layout Sort Group.
When the option "Sync layout and sorting preferences across directories", the adaptive layout is disable in toolbar but not in context menu. It's fixed.
The layout context menu replaces icons by toggle indicator. This lets you know which layout is active.
Validation
How did you test these changes?