Rich command: NewTab + DuplicateTab #11596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should support both shortcuts. |
|
Ok. I will implement the custom commands. This will allow to easily have several Hotkeys for the same action. I will update this pr after committing the custom commands. This pr is therefore pending. |
78 tasks
|
There was no need for a second hotkey because I confused 2 commands. Ctrl+Shift+K is for DuplicateTab and not NewTab. Of course, the multiple hotkeys will have other uses. I updated this pr which can be reviewed. |
yaira2
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Here are 2 new commands. For other navigation controls, I'm going to need a context to get the current IMultitaskingControl.
There were 2 keyboard shortcuts for NewTab (Ctrl+T and Ctrl+Shift+K). The second has been deleted but can be put back if necessary.
Validation
How did you test these changes?