Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add selection RichCommands #11502

Merged
merged 4 commits into from
Feb 28, 2023

Conversation

cinqmilleans
Copy link
Contributor

@cinqmilleans cinqmilleans commented Feb 28, 2023

Resolved / Related Issues
*Adds commands SelectAll and ClearSelection and InvertSelection and MultiSelect. The menu is disabled if the command has no effect.

  • Adds properties HasSelection and SelectedItem to IContentPageContext for to make it easier. SelectedItem is null when the selection does not contain one and only one element.
  • The Ctrl+A hotkey is handled in the file lists and the appropriate command is reissued, to be able to reassign this hotkey.
  • Rich commands use a new HotKeyText property, which is null when the hotkey is empty. Otherwise, the menus display None instead of displaying nothing.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@yaira2
Copy link
Member

yaira2 commented Feb 28, 2023

Thank you

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 28, 2023
@yaira2 yaira2 changed the title Rich command: Selection Feature: Add selection rich commands Feb 28, 2023
@yaira2 yaira2 changed the title Feature: Add selection rich commands Feature: Add selection RichCommands Feb 28, 2023
@yaira2 yaira2 merged commit 6a112b0 into files-community:main Feb 28, 2023
@QuaintMako QuaintMako mentioned this pull request Mar 3, 2023
78 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants