-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rich command: Context + Restore #11472
Conversation
I updated to resolve an incompatibility with the latest commits. This forced me to integrate the management of OpacityIcon
When all the commands have been converted, it will be possible to replace ContextMenuFlyoutItemViewModel with an interface and 3 implementations to improve code and performance. Known bug: In the context menu, the Restore entry of a RecycleBin item has no icon. However, the element does have an OpacityIcon content. I don't think the bug is related to this code. |
I noticed this as well, I think we can leave as is for now (same issue in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolved / Related Issues
This pr adds the first and main context used by actions. A context is an observable service that easily provides actions with properties that are difficult to know. To observe properties of the current page, you must notify the properties when it changes or when a parent or ancestor object changes.
Validation
How did you test these changes?