Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichCommand: Glyph + ContextMenu + EmptyRecycleBinAction #11415

Merged
merged 6 commits into from
Feb 22, 2023

Conversation

cinqmilleans
Copy link
Contributor

@cinqmilleans cinqmilleans commented Feb 22, 2023

Resolved / Related Issues

  • Usage of glyphs in IAction. This simplifies the use of icons with the FontIcon and ColoredIcon properties of IRichCommand.
  • Simplifies the creation of context menus. It is possible to pass a RichCommand to ContextMenuFlyoutItemViewModel to initialize it.
  • Added RichCommand EmptyRecycleBin, which uses glyphs. This command is used everywhere, including the sidebar. Old commands are deleted. This new action does not yet use the IsExecutable property. This requires the context class and will be the subject of a future pr.
  • A behavior has changed slightly. In the context menu of the RecycleBin page, the RecycleBin command is no longer active if the RecycleBin is empty. This seemed like a bug to me.
  • A bug has been fixed in the parser of HotKey (not yet used).
  • The next step is to add the context. This is the last part of the command base. Then, it will be necessary to convert the current commands (actions + use in the views).

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@yaira2
Copy link
Member

yaira2 commented Feb 22, 2023

Can you add support for OpacityIcon? We're currently only using them in the toolbar but we're going to want to use them in the context menu as well.

@cinqmilleans
Copy link
Contributor Author

I haven't looked at this class but probably it's possible. I will watch for the next iteration.

@yaira2
Copy link
Member

yaira2 commented Feb 22, 2023

@cinqmilleans please fill out validation steps and add any other steps you used. This helps us know what to test for when reviewing the PR.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 requested a review from d2dyno1 February 22, 2023 21:58
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 22, 2023
@yaira2 yaira2 merged commit 2f36a71 into files-community:main Feb 22, 2023
@QuaintMako QuaintMako mentioned this pull request Feb 26, 2023
78 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants