Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where option to hide details pane wasn't working #11230

Merged
merged 1 commit into from
Feb 10, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/Files.App/UserControls/Pane/PreviewPane.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,7 @@
BorderThickness="0,0,0,1">
<Grid.RowDefinitions>
<RowDefinition Height="2*" MinHeight="100" />
<RowDefinition
x:Name="PropertiesRow"
Height="3*"
MinHeight="100" />
<RowDefinition x:Name="PropertiesRow" Height="3*" />
</Grid.RowDefinitions>

<Grid
Expand Down Expand Up @@ -105,14 +102,18 @@
Visibility="Collapsed">
<ItemsControl.ItemTemplate>
<DataTemplate x:DataType="properties:FileProperty">
<Grid HorizontalAlignment="Stretch" AutomationProperties.Name="{x:Bind Name, Mode=OneWay}">
<Grid
HorizontalAlignment="Stretch"
AutomationProperties.Name="{x:Bind Name, Mode=OneWay}"
ColumnSpacing="12">
<Grid.ColumnDefinitions>
<ColumnDefinition />
<ColumnDefinition />
<ColumnDefinition Width="1*" />
<ColumnDefinition Width="2*" />
</Grid.ColumnDefinitions>
<!-- Property -->
<TextBlock
HorizontalAlignment="Stretch"
VerticalAlignment="Center"
MaxLines="2"
Style="{StaticResource BodyTextBlockStyle}"
Text="{x:Bind Name, Mode=OneWay}" />
Expand All @@ -121,6 +122,7 @@
<TextBox
x:Name="PropertyValueTemplateTextBox"
Grid.Column="1"
MaxHeight="50"
HorizontalAlignment="Stretch"
Background="Transparent"
BorderBrush="Transparent"
Expand Down Expand Up @@ -200,6 +202,7 @@
</VisualState.StateTriggers>
<VisualState.Setters>
<Setter Target="RootPropertiesScrollViewer.Visibility" Value="Collapsed" />
<Setter Target="PropertiesRow.Height" Value="0" />
</VisualState.Setters>
</VisualState>
</VisualStateGroup>
Expand Down