This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
feat: gateway.ContentPathKey as affinity key #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
this removes the need for polluting public API with interface{}
lidel
changed the title
lidel
reviewed
Feb 24, 2023
Comment on lines
+140
to
+158
| // https://github.com/ipfs/bifrost-gateway/issues/53#issuecomment-1442732865 | ||
| if affG := ctx.Value(gateway.ContentPathKey); affG != nil { | ||
| contentPath := affG.(ipath.Path).String() | ||
|
|
||
| // Using exact content path seems to work better for initial website loads | ||
| // because it groups all blocks related to the single file, | ||
| // but at the same time spreads files across multiple L1s | ||
| // which removes the risk of specific L1 becoming a cache hot spot for | ||
| // websites with huge DAG like /ipns/en.wikipedia-on-ipfs.org | ||
| return contentPath | ||
|
|
||
| /* TODO: if we ever want to revisit, and group per root CID of entire DAG: | ||
| const contentRootIdx = 2 | ||
| if parts := strings.Split(contentPath, "/"); len(parts) > contentRootIdx { | ||
| // use top level contentRoot ('id' from /ipfs/id or /ipns/id) as affinity key | ||
| return parts[contentRootIdx] | ||
| } | ||
| */ | ||
| } |
There was a problem hiding this comment.
ℹ️ @willscott @aschmahmann FYI
lidel
approved these changes
Feb 24, 2023
willscott
approved these changes
Feb 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context keys should not be strings: https://pkg.go.dev/context#WithValue. I'm not sure whether changing it toRefactored it so we dont useinterface{}- to allow for custom types - will prevent bugs, but I hope so.interface{}– @lidel