Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

Expose peer pool health as metric #35

Closed
lidel opened this issue Feb 20, 2023 · 0 comments · Fixed by #37
Closed

Expose peer pool health as metric #35

lidel opened this issue Feb 20, 2023 · 0 comments · Fixed by #37
Assignees
@aarshkshah1992

Comments

@lidel
Copy link
Contributor

lidel commented Feb 20, 2023 •
edited
Loading

Caboose is running weighting algorith introduced in #19 and already tracks the pool_size

Thoughts on adding second metric (histogram?) that tracks number of peers with positive vs negative weights?

This would allow us to track pool health over time, identify causes of things like perf degradation, or spikes in certain hours.

cc @willscott @gmasgras for visibility
@lidel lidel changed the title Expose the number of peers and number of useful peers Expose peer pool health as metric Feb 20, 2023
@aarshkshah1992 aarshkshah1992 self-assigned this Feb 20, 2023
willscott added a commit that referenced this issue Feb 21, 2023
@willscott
add a metric of pool health
77274b1 
fix #35
@willscott willscott mentioned this issue Feb 21, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aarshkshah1992 aarshkshah1992

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add a metric of pool health filecoin-saturn/caboose
2 participants
@lidel @aarshkshah1992