-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand all details, but the changes look reasonable to me 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bajtos annotated the changes ftr
Ok the code signing tool used (gon) doesn't support signing arm yet: mitchellh/gon#40 |
at least signing the x86_64 works so far |
@bajtos what do you think we should do strategy wise? Wait until |
@bajtos you can check out the release artifacts here: https://github.com/filecoin-saturn/L2-node/actions/runs/3099194083 |
Hmm, that's a bummer! 😫
I don't know how much work is required to sign & notarise an app manually. I suspect it will be a non-trivial thing. I think it's better to work with gon maintainers to help everybody understand what changes are need to make gon work for darwin/arm64. Maybe it's just a matter of configuring their GoReleaser to build both Intel and Arm64 versions? https://github.com/mitchellh/gon/blob/master/.goreleaser.yml I think just figuring out the action plan to get arm64 support will be a great contribution and it can enable other community members to do the actual work. |
I reached out here: mitchellh/gon#40 (comment) I also cleaned up the branch, could you review please? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one suggestion to consider.
Co-authored-by: Miroslav Bajtoš <[email protected]>
For #35