sampling randomness out of range results in revert not fault (#2409)

also add error code 1 to RevertErrorWrap to be consistent
filecoin-project · Mar 25, 2019 · f120fe9 · f120fe9
1 parent 26039fe
commit f120fe9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/actor/builtin/miner/miner.go b/actor/builtin/miner/miner.go
@@ -682,7 +682,7 @@ func (ma *Actor) SubmitPoSt(ctx exec.VMContext, postProofs []proofs.PoStProof) (
 
 			seed, err := currentProvingPeriodPoStChallengeSeed(ctx, state)
 			if err != nil {
-				return nil, errors.FaultErrorWrap(err, "failed to sample chain for challenge seed")
+				return nil, errors.RevertErrorWrap(err, "failed to sample chain for challenge seed")
 			}
 
 			var commRs []proofs.CommR

diff --git a/vm/errors/errors.go b/vm/errors/errors.go
@@ -57,7 +57,7 @@ func NewCodedRevertErrorf(code uint8, format string, args ...interface{}) error
 
 // RevertErrorWrap wraps a given error in a RevertError.
 func RevertErrorWrap(err error, msg string) error {
-	return &RevertError{err: err, msg: msg}
+	return &RevertError{err: err, msg: msg, code: 1}
 }
 
 // RevertErrorWrapf wraps a given error in a RevertError and adds a message