This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
Confirm bug and failure catch #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
approved these changes
Mar 4, 2022
There was a problem hiding this comment.
Thanks! Wanna add a note above the test (or the assertion) saying that it demonstrates a bug (and should be changed when the fix is in)?
Lest the universe end tomorrow and the post-universe life be confused by why this test is asserting for seemingly incorrect behaviour.
ZenGround0
force-pushed
the
test/multi-dline-rpu
branch
from
46e0ca8
to
1cb45d6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proving out the bug in #1577 and demonstrating that it fails the message without causing harm